Added multi-arch support including ARM. #241
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Hi @jqmichael. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/M
| - name: Build container image | ||
| run: | | ||
| docker build -t aws-efs-csi-driver . |
There was a problem hiding this comment.
No need for a separate build step because docker buildx build and push are run at the same step.
There was a problem hiding this comment.
The docker buildx build subcommand has a number of flags which determine where the final image will be stored. By default, i.e. if none of the flags are specified, the resulting image will remain captive in docker’s internal build cache. This is unlike the regular docker build command which stores the resulting image in the local docker images list.
--push: This flag tells docker to push the resulting image to a docker registry. This currently is the best way to store multi-architecture images.
https://medium.com/@artur.klauser/building-multi-architecture-docker-images-with-buildx-27d80f7e2408
| docker buildx build \ | ||
| -t $REPO:$TAG \ | ||
| --platform=linux/amd64,linux/arm64 \ | ||
| --progress plain \ | ||
| --push . |
There was a problem hiding this comment.
docker buildx build and push are done as a single step.
There was a problem hiding this comment.
The docker buildx build subcommand has a number of flags which determine where the final image will be stored. By default, i.e. if none of the flags are specified, the resulting image will remain captive in docker’s internal build cache. This is unlike the regular docker build command which stores the resulting image in the local docker images list.
--push: This flag tells docker to push the resulting image to a docker registry. This currently is the best way to store multi-architecture images.
https://medium.com/@artur.klauser/building-multi-architecture-docker-images-with-buildx-27d80f7e2408
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jqmichael, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
merging because coveralls is bugged |
Is this a bug fix or adding new feature?
feature.
What is this PR about? / Why do we need it?
Added multi-arch support including ARM.
What testing is done?
Verify the
/bin/aws-efs-csi-driverbinary was ARM when simulating an ARM environment with docker run.Launched an
a1instance, which is ARM architecture, and verified the driver worked with the TLS example (had to use csi-node-driver-registrar from https://github.com/raspbernetes/multi-arch-images since upstream image isn't available yet).